Gitweb links:

...log 
http://git.netsurf-browser.org/netsurf.git/shortlog/de7244a17017c3aa35d05b4229e49f8959dcc92d
...commit 
http://git.netsurf-browser.org/netsurf.git/commit/de7244a17017c3aa35d05b4229e49f8959dcc92d
...tree 
http://git.netsurf-browser.org/netsurf.git/tree/de7244a17017c3aa35d05b4229e49f8959dcc92d

The branch, master has been updated
       via  de7244a17017c3aa35d05b4229e49f8959dcc92d (commit)
      from  59078c3f20ab76fce3358c2a101d3c7d0584935a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commitdiff 
http://git.netsurf-browser.org/netsurf.git/commit/?id=de7244a17017c3aa35d05b4229e49f8959dcc92d
commit de7244a17017c3aa35d05b4229e49f8959dcc92d
Author: Michael Drake <[email protected]>
Commit: Michael Drake <[email protected]>

    risc os: Don't let URL complete start consume URL bar drags.

diff --git a/frontends/riscos/toolbar.c b/frontends/riscos/toolbar.c
index b3acba5..c6a882a 100644
--- a/frontends/riscos/toolbar.c
+++ b/frontends/riscos/toolbar.c
@@ -1115,18 +1115,20 @@ bool ro_toolbar_click(wimp_pointer *pointer)
                return true;
        }
 
-       /* Nothing else has handled this, so try passing it to the
-        * URL Complete module.
-        *
-        * \TODO -- This should really move into the URL Bar module, as
-        *          URL Complete is really an extension to that.
-        */
-
-       if (toolbar->url != NULL && toolbar->url_display &&
-                       ro_gui_url_bar_test_for_text_field_click(toolbar->url,
-                               pointer)) {
-               ro_gui_url_complete_start(toolbar);
-               return true;
+       if (pointer->buttons != wimp_DRAG_SELECT &&
+           pointer->buttons != wimp_DRAG_ADJUST) {
+               /* Nothing else has handled this click, so try passing it to
+                * the URL Complete module.
+                *
+                * \TODO -- This should really move into the URL Bar module, as
+                *          URL Complete is really an extension to that.
+                */
+               if (toolbar->url != NULL && toolbar->url_display &&
+                               ro_gui_url_bar_test_for_text_field_click(
+                                               toolbar->url, pointer)) {
+                       ro_gui_url_complete_start(toolbar);
+                       return true;
+               }
        }
 
        return false;


-----------------------------------------------------------------------

Summary of changes:
 frontends/riscos/toolbar.c |   26 ++++++++++++++------------
 1 file changed, 14 insertions(+), 12 deletions(-)

diff --git a/frontends/riscos/toolbar.c b/frontends/riscos/toolbar.c
index b3acba5..c6a882a 100644
--- a/frontends/riscos/toolbar.c
+++ b/frontends/riscos/toolbar.c
@@ -1115,18 +1115,20 @@ bool ro_toolbar_click(wimp_pointer *pointer)
                return true;
        }
 
-       /* Nothing else has handled this, so try passing it to the
-        * URL Complete module.
-        *
-        * \TODO -- This should really move into the URL Bar module, as
-        *          URL Complete is really an extension to that.
-        */
-
-       if (toolbar->url != NULL && toolbar->url_display &&
-                       ro_gui_url_bar_test_for_text_field_click(toolbar->url,
-                               pointer)) {
-               ro_gui_url_complete_start(toolbar);
-               return true;
+       if (pointer->buttons != wimp_DRAG_SELECT &&
+           pointer->buttons != wimp_DRAG_ADJUST) {
+               /* Nothing else has handled this click, so try passing it to
+                * the URL Complete module.
+                *
+                * \TODO -- This should really move into the URL Bar module, as
+                *          URL Complete is really an extension to that.
+                */
+               if (toolbar->url != NULL && toolbar->url_display &&
+                               ro_gui_url_bar_test_for_text_field_click(
+                                               toolbar->url, pointer)) {
+                       ro_gui_url_complete_start(toolbar);
+                       return true;
+               }
        }
 
        return false;


-- 
NetSurf Browser
_______________________________________________
netsurf-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to