Gitweb links:
...log
http://git.netsurf-browser.org/libdom.git/shortlog/631f016a9ccff344f4dcb0b57e8ef1cf275e175c
...commit
http://git.netsurf-browser.org/libdom.git/commit/631f016a9ccff344f4dcb0b57e8ef1cf275e175c
...tree
http://git.netsurf-browser.org/libdom.git/tree/631f016a9ccff344f4dcb0b57e8ef1cf275e175c
The branch, master has been updated
via 631f016a9ccff344f4dcb0b57e8ef1cf275e175c (commit)
from 78cd9ec509366e8a1fd61f077aba3a6537255ad1 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commitdiff
http://git.netsurf-browser.org/libdom.git/commit/?id=631f016a9ccff344f4dcb0b57e8ef1cf275e175c
commit 631f016a9ccff344f4dcb0b57e8ef1cf275e175c
Author: Michael Drake <[email protected]>
Commit: Michael Drake <[email protected]>
Element: Change API to return a reference to callers.
diff --git a/src/core/element.c b/src/core/element.c
index 66d0390..05dc8c6 100644
--- a/src/core/element.c
+++ b/src/core/element.c
@@ -1232,12 +1232,11 @@ dom_exception _dom_element_has_class(struct dom_element
*element,
/**
* Get a named ancestor node
*
- * If the caller wants to keep the returned node around, it must take its
- * own ref. This call returns a borrow.
+ * The caller is responsible for unreffing the returned node.
*
* \param element Element to consider
* \param name Node name to look for
- * \param parent Pointer to location to receive borrowed node pointer
+ * \param ancestor Pointer to location to receive node.
* \return DOM_NO_ERR.
*/
dom_exception dom_element_named_ancestor_node(dom_element *element,
@@ -1254,7 +1253,7 @@ dom_exception dom_element_named_ancestor_node(dom_element
*element,
assert(node->name != NULL);
if (dom_string_caseless_lwc_isequal(node->name, name)) {
- *ancestor = (dom_element *)node;
+ *ancestor = (dom_element *)dom_node_ref(node);
break;
}
}
@@ -1265,12 +1264,11 @@ dom_exception
dom_element_named_ancestor_node(dom_element *element,
/**
* Get a named parent node
*
- * If the caller wants to keep the returned node around, it must take its
- * own ref. This call returns a borrow.
+ * The caller is responsible for unreffing the returned node.
*
* \param element Element to consider
* \param name Node name to look for
- * \param parent Pointer to location to receive borrowed node pointer
+ * \param parent Pointer to location to receive node pointer
* \return DOM_NO_ERR.
*/
dom_exception dom_element_named_parent_node(dom_element *element,
@@ -1287,7 +1285,7 @@ dom_exception dom_element_named_parent_node(dom_element
*element,
assert(node->name != NULL);
if (dom_string_caseless_lwc_isequal(node->name, name)) {
- *parent = (dom_element *)node;
+ *parent = (dom_element *)dom_node_ref(node);
}
break;
}
@@ -1298,12 +1296,11 @@ dom_exception dom_element_named_parent_node(dom_element
*element,
/**
* Get a named parent node
*
- * If the caller wants to keep the returned node around, it must take its
- * own ref. This call returns a borrow.
+ * The caller is responsible for unreffing the returned node.
*
* \param element Element to consider
* \param name Node name to look for
- * \param parent Pointer to location to receive borrowed node pointer
+ * \param parent Pointer to location to receive node pointer
* \return DOM_NO_ERR.
*/
dom_exception dom_element_parent_node(dom_element *element,
@@ -1317,7 +1314,7 @@ dom_exception dom_element_parent_node(dom_element
*element,
if (node->type != DOM_ELEMENT_NODE)
continue;
- *parent = (dom_element *)node;
+ *parent = (dom_element *)dom_node_ref(node);
break;
}
-----------------------------------------------------------------------
Summary of changes:
src/core/element.c | 21 +++++++++------------
1 file changed, 9 insertions(+), 12 deletions(-)
diff --git a/src/core/element.c b/src/core/element.c
index 66d0390..05dc8c6 100644
--- a/src/core/element.c
+++ b/src/core/element.c
@@ -1232,12 +1232,11 @@ dom_exception _dom_element_has_class(struct dom_element
*element,
/**
* Get a named ancestor node
*
- * If the caller wants to keep the returned node around, it must take its
- * own ref. This call returns a borrow.
+ * The caller is responsible for unreffing the returned node.
*
* \param element Element to consider
* \param name Node name to look for
- * \param parent Pointer to location to receive borrowed node pointer
+ * \param ancestor Pointer to location to receive node.
* \return DOM_NO_ERR.
*/
dom_exception dom_element_named_ancestor_node(dom_element *element,
@@ -1254,7 +1253,7 @@ dom_exception dom_element_named_ancestor_node(dom_element
*element,
assert(node->name != NULL);
if (dom_string_caseless_lwc_isequal(node->name, name)) {
- *ancestor = (dom_element *)node;
+ *ancestor = (dom_element *)dom_node_ref(node);
break;
}
}
@@ -1265,12 +1264,11 @@ dom_exception
dom_element_named_ancestor_node(dom_element *element,
/**
* Get a named parent node
*
- * If the caller wants to keep the returned node around, it must take its
- * own ref. This call returns a borrow.
+ * The caller is responsible for unreffing the returned node.
*
* \param element Element to consider
* \param name Node name to look for
- * \param parent Pointer to location to receive borrowed node pointer
+ * \param parent Pointer to location to receive node pointer
* \return DOM_NO_ERR.
*/
dom_exception dom_element_named_parent_node(dom_element *element,
@@ -1287,7 +1285,7 @@ dom_exception dom_element_named_parent_node(dom_element
*element,
assert(node->name != NULL);
if (dom_string_caseless_lwc_isequal(node->name, name)) {
- *parent = (dom_element *)node;
+ *parent = (dom_element *)dom_node_ref(node);
}
break;
}
@@ -1298,12 +1296,11 @@ dom_exception dom_element_named_parent_node(dom_element
*element,
/**
* Get a named parent node
*
- * If the caller wants to keep the returned node around, it must take its
- * own ref. This call returns a borrow.
+ * The caller is responsible for unreffing the returned node.
*
* \param element Element to consider
* \param name Node name to look for
- * \param parent Pointer to location to receive borrowed node pointer
+ * \param parent Pointer to location to receive node pointer
* \return DOM_NO_ERR.
*/
dom_exception dom_element_parent_node(dom_element *element,
@@ -1317,7 +1314,7 @@ dom_exception dom_element_parent_node(dom_element
*element,
if (node->type != DOM_ELEMENT_NODE)
continue;
- *parent = (dom_element *)node;
+ *parent = (dom_element *)dom_node_ref(node);
break;
}
--
Document Object Model library
_______________________________________________
netsurf-commits mailing list -- [email protected]
To unsubscribe send an email to [email protected]
