Hi, This weeks goal was to finish gtk printing. The first thing I have done was handling the 'Page Setup' dialog. Now it is possible to choose the required rotation as well as different paper sizes. It allows also managing custom sizes and margins.
I have fixed (almost) all bugs found in gtk printing during the last two weeks. The background color was overflowing on the right side on some pages, this was handled by normalization of the clipping and fill bounds. A wrong number of pages was printed, it was necessary to pass the height of the content as a parameter in the print functions. I am not sure about this, it was the simplest way to do that but it needed a change in the print interface so it's not perfect. After scaling over 1.0 the content on the page was clipped to a smaller rectangle, it turned out to be a bug in the print function affecting PDF printing, too. The last bug was too high positioned text, which caused clipping the words on the top. This one was most difficult to find and unluckily wasted a lot of my time. It turned out to be a problem with the nsfont_paint function, which I have copied from font_pango.c. This version used pango/gdk as default (with not defined CAIRO_VERSION) to render the text but for my needs I left only the Cairo part what caused the bug to show up (what didn't happen in the browser window for the mentioned reason). The good side is that I found a bug in the window plotting code this way. I made the changes in both versions of the function. The bug I didn't manage to fix is one I thought was connected with the previous one. After choosing the 'Landscape' rotation some/all? first letters in each line disappear. I will try to manage this one at the end of this week if I have some time left or during the 4 week. Despite the gtk stuff I have also done some code maintaince work. I changed the code according to jmb's review, solved the netsurf.glade clash and what is most important I merged from trunk to my branch. During the next week I will stick to my timeline: adding UTF-8 support to Haru and the posibilty of changing print settings. Before I start with that I will apply the changes suggested by joty's review. Let me know if you have any comments :)
