In message <[EMAIL PROTECTED]>
"Adam Blokus" <[EMAIL PROTECTED]> wrote:
> [...]
> I fixed also the bug giving 'the division by 0' error in Adobe Reader
> (I simply check whether one of the dimensions is 0 and if that's the case
> I return true as I think we can assume that plotting
> the actually non-existing image was successful).
Yes that definately helped. Thanks.
> However, after doing so I got another error message caused by embedded
> jpg's so I had to comment it out until I find out what's the problem.
Ok.
> on 2008/7/20 John Tytgat wrote:
>
> > Use LOG() for reporting the error message. Is there anyway to recover
> > instead of exit() (which is a no-go as this makes your browser go
> > away) ? I believe Haru suggests setjmp/longjmp.
>
> The exit was for debugging purposes only so I closed it in define's.
> Is it OK if the error handler logs only the error and the cleaning etc. is
> done
> where the function failed? This way we can avoid using setjmp/longjmp
> which IMHO make the code less readable.
That's fine and actually also my preference.
> [...]
> > Is it actual possible to have settings->output being NULL ? If so, better
> > give an error message upfront and don't do any PDF generation at all as
> > writing a file to whatever the current directory is, is not good.
>
> What is the way of informing the user of non-critical errors?
warn_user()
Now that your branch has been merged to trunk for the first time, it would
be good if you could regulary sync your branch with the changes made on
trunk. I did this just after your branch merge to convince myself svnmerge
is working as expected but for now on, please do it yourself and when it
suits you. This will allow us to get your next improvements on trunk
letting more people enjoy your work.
John.
--
John Tytgat
[EMAIL PROTECTED]
