Daniel Silverstone wrote: > On Mon, 2009-07-13 at 06:17 +0200, Mark wrote: > >> I would encourage Rob / Daniel to try to make >> time to review the changes please so that the branch could be merged >> while it's relatively fresh :-) >> > I need to know what I'm reviewing. > > Rob suggested that it'd be better in the long-term to review in smaller > chunks, but you're saying that it'll be easier to review the whole thing > in one go. > Rob is definitely right in one way, as it's a rather unwieldy task all as one big review; I tried to address that difference, keeping it as the one branch for compatibility, while making manageable feature-oriented sub-tasks of the review; I'd suggest reviewing overview/glade/misc first, then the individual features in whatever order seems appropriate, such as chronological favicon - search - save - customization - theme; clearly there's a minor difficulty in that the changes to gtk_scaffolding.c are really linked to virtually every branch; hopefully we are capable of coping :-)
as far as compatibility is relevant, the way I see it is that it was a relatively large rather delicate task trying to merge the branches; not to speak of the additional work involving the team to correct merge errors involving amiga/riscos; so although the fact that I have already merged the branches should allow me to re-merge them after individual review without enormous amounts of additional work, there is definitely repetition in it, plus it adds to the work of more people than me, in checking / repatching amiga/riscos/beos; then there's the question of the changes that a merger induces needing a review of its own; possibly as much as one more review per branch, the changes that customization / theming brought to the structure of gtk_scaffolding.c being so major; so as I say, really we're looking at up to 3 times the work reviewing the branches in their original state compared to reviewing them as sub-features from the main branch > I will say that I can't do any more than a style and > cursory-obvious-issues review if it's all in one block, but I *am* > prepared to do that. However since no decision was made yesterday I > didn't get anything done yesterday and I won't have time until I'm in > Spain now. > > Rob: I think you're going to have to do the first pass review here. > Sorry. > > D. > Well let's keep it under advisement; perhaps whoever finds time first could do so? Best regards Mark http://www.halloit.com Key ID 046B65CF
