On Tue, Jul 14, 2009 at 07:36:09AM +0200, Mark wrote: > Vincent Sanders wrote: > > Ok here is the next chunk of plotter refactor. This one cleans up the > > interface for arc, disc and polygon and re-arranges the plotter > > structure in line with that described in the API document. > > > > One wrinkle is that teh gtk plotters got so messy that I was a bit > > naughty and rearranged them without forward declarations as i was > > tired of having to change teh function declarations twice. > > > > Again compile and run tested successfully on GTK and framebuffer. > > > > > Hi, > > I've got one comment I hope you don't mind; it's that TRANSPARENT is > defined in windows headers, so generally I've refactored NetSurf's > TRANSPARENT to NS_TRANSPARENT in my branch; as you're refactoring > plotters generally, perhaps rather than me needing to resolve that at > every increment you could refactor it yourself? > > one caveat, there is an svgtiny_TRANSPARENT defined too;
I look forward to a single function patch from you to achive this once this current refactor has been merged. -- Regards Vincent http://www.kyllikki.org/
