On Sat, 2009-08-01 at 12:27 +0100, John-Mark Bell wrote: > On Sat, 2009-08-01 at 02:32 +0000, [email protected] wrote: > > > Modified: branches/struggleyb/libdom-remain/bindings/xml/xmlparser.c > > URL: > > http://source.netsurf-browser.org/branches/struggleyb/libdom-remain/bindings/xml/xmlparser.c?rev=8936&r1=8935&r2=8936&view=diff > > ============================================================================== > > --- branches/struggleyb/libdom-remain/bindings/xml/xmlparser.c (original) > > +++ branches/struggleyb/libdom-remain/bindings/xml/xmlparser.c Fri Jul 31 > > 21:32:27 2009 > > @@ -297,6 +297,8 @@ > > dom_xml_error dom_xml_parser_completed(dom_xml_parser *parser) > > { > > xmlParserErrors err; > > + lwc_string *name = NULL; > > + lwc_error lerr; > > > > err = xmlParseChunk(parser->xml_ctx, "", 0, 1); > > if (err != XML_ERR_OK) { > > @@ -306,6 +308,13 @@ > > } > > > > parser->complete = true; > > + > > + lerr = lwc_context_intern(parser->ctx, "id", strlen("id"), &name); > > + if (lerr != lwc_error_ok) > > + return DOM_XML_LIBXML_ERR | lerr; > > You probably want a todo here mentioning that the id attribute name > should be extracted from the schema.
One further thing: this isn't a libxml error. J.
