On Tue, 2009-08-04 at 18:15 +0100, Chris Young wrote: > On Mon, 03 Aug 2009 22:07:06 -0000, wrote: > > > URL: http://source.netsurf-browser.org?rev=9027&view=rev > > Log: > > Stop utterly insane palette entry population. > > Palette entries are always ABGR, regardless of platform endianness. > > This change probably breaks big-endian platforms which, under the > > old approach, had palette entries of the form RGBA (assuming I > > understood the code correctly). > > Yes it does, and it totally breaks NetSurf* as GIFs now have a > different byte order to every other bitmap. > > Can we either change all the bitmap outputs to ABGR or (preferably) > leave them all as RGBA please?
Colour component ordering is orthogonal to endianness, so the current mess within NetSurf (and, apparently, libns*) whereby bitmap component ordering depends on the CPU's endianness is insane. When I suggested making bitmap component ordering the same as that of colour primitives (i.e. ABGR), you said that the Amiga bitmap APIs couldn't handle it and that you'd prefer that we left it in its current inconsistent state. Has your position changed here? RGBA isn't an option, as RISC OS simply cannot cope with that at all. J.
