On Thu, 8 Nov 2012 19:37:38 +0000, Vincent Sanders wrote: > > Hmm, still seems to be adding $s and $d. I don't think I'm getting as > > many errors though, so you've probably just missed one. > > do not *think* so..but i could be wrong. have you made netsurf clean > and definitely regenerated with master branch nsgenbind?
No, I've been stupid. I forgot to add TARGET=amiga when I cross-compiled nsgenbind, and ended up copying the old version back over again! Unsurprisingly, it works now :/ > > > along with compatability macro magic that *might* mean 1.7 > > > works in mainline > > > > > > javascript/jsapi.h now has a 1.7 section which should be updated with > > > stuff i got wrong ;-) > > > > Getting there. I think jsapi.h is ok, but the generated window.c has > > some "trace" stuff in it which 1.7 doesn't like. I can get it to > > build by commenting it out, but I'm not sure how important it is or > > what it does: > > > > build-amiga-amiga/window.c:27: error: expected ) before * token > > build-amiga-amiga/window.c:33: error: JSCLASS_MARK_IS_TRACE undeclared here > > (not in a function) > > build-amiga-amiga/window.c:45: error: jsclass_mark undeclared here (not in > > a function) > > build-amiga-amiga/window.c: In function jsapi_property_window_get: > > build-amiga-amiga/window.c:511: warning: implicit declaration of function > > JS_SET_RVAL > > build-amiga-amiga/window.c: At top level: > > build-amiga-amiga/window.c:2479: error: expected ) before * token > > This i have fixed already (I think) Still erroring - it doesn't like the JSTracer type and JSCLASS_MARK_IS_TRACE. Looks like there is a different type of callback for 1.7 so might need some compatibility magic there. > > I think JS_SET_RVAL should be JSAPI_SET_RVAL though. > > migt be, though some places are using the "real" spidermonkey macro as > its just the native function call that has changed signature every > bloody release since 1.7.0 :-( Ah, 1.7 doesn't have it though. I've added it to the jsapi.h header. Chris
