On Mon, Oct 26, 2015 at 10:03:27PM +0000, Dave Higton wrote: > This patch provides a partial fix for bug 2368.
In principle the change is good (aside from the opening curly brace should be on the same line as the if). However the error message is not useful to the user, it is accurate of course, but anything translated is for the general user ought to be more descriptive. May I suggest "Unable to convert image to sprite" would be more helpful in this context as it converys to the user exactly what action the browser was unable to perform. Additionally Michael has suggested that the RISC OS idiomatic thing to do would be to grey out the save to sprite option altogether when the action is not valid. This would need to be in addition to the error here as "on demand" conversion could potentialy mean the image data is not available. > > The second image in the cited URL is CMY, and the libraries fail to > convert it. The resulting bitmap is null. It is rendered as a > pink rectangle. If the user tries to export it as a sprite, > riscos_bitmap_save() is called, which immediately attempts a null > dereference, causing a crash (when I tried it, it was a serious > crash that brought the whole machine down). snipped the rest -- Regards Vincent http://www.kyllikki.org/
