Maamoun TK <maamoun...@googlemail.com> writes: > I got your point. Small macros are easy to handle but maybe adding some > in-between comments would also make it easier to go through by reader. > please check out my last edit on poly1305.m4
Thanks, I've had a look at https://git.lysator.liu.se/nettle/nettle/-/merge_requests/56 (without trying to get all the fine details), and it looks much more readable. One question, the DEFINES_BLOCK_R64 macro in poly1305.m4. It would be nice if the including .asm file could stay in full control of register allocation. Perhaps that macro (and BLOCK_R64 where it's used) could take register ranges as argument, e.g, DEFINES_BLOCK_R64(6, 0) dnl first r-register, first v-register to have it use registers r6, r7, ..., r9, and v0, v1, ..., v10? With the current version, it's a bit odd that there are gaps in the list of defined registers (r6, r8, v0, v3 used, but not r7, v1, v2), and the caller needs to be aware of that. One could do something similar for other DEFINE_* macros, but less important since those are defined in the .asm file and used only once (I think?). Regards, /Niels -- Niels Möller. PGP key CB4962D070D77D7FCB8BA36271D8F1FF368C6677. Internet email is subject to wholesale government surveillance. _______________________________________________ nettle-bugs mailing list -- nettle-bugs@lists.lysator.liu.se To unsubscribe send an email to nettle-bugs-le...@lists.lysator.liu.se
