------- Original Message -------
On Wednesday, February 15th, 2023 at 10:10 PM, Niels Möller 
<ni...@lysator.liu.se> wrote:


> r...@foxi.me writes:
> 
> > do I need to say anything?
> 
> 
> Please do, to provide a bit of context. I'm not at all familiar with
> midipix. Some questions:
> 
> 1. Is this aimed for native (windows) builds, or cross builds, or both?
> 

both native and cross-compilation is supported, midipix is a posix layer like 
cygwin.

> 2. How does shared library linking differ from mingw32/sygwin case, and
> from the default case? It looks like you use unix conventions for
> names of the shared library files (.so, not .dll), you just pass an
> extra linker flag --out-dsolib?
> 

yeah we use the "normal" unix conventions for shared libraries, --out-dsolib is 
for emitting midipix platform-specific import libraries.

> 3. What configure options are you using to enable and test this
> configuration? Would it be autodetected (for native builds) if
> config.guess was updated to latest version?
> 

other than the usual cross-compilation dance with --host, we only pass 
--disable-fat. wget, curl and many other things are built against gnutls and 
nettle in turn and work as one would expect.

> Patch itself looks reasonable to me, even though it would be nice if
> there were some easy way to reduce duplication.
> 

Certainly... I just followed the existing host entries already found in 
configure.ac

> Regards,
> /Niels
> 
> > From 99d2f1f5d6bb6f51f13af1af7dd62c3c6b5f8a18 Mon Sep 17 00:00:00 2001
> > From: =?UTF-8?q?=C3=98rjan=20Malde?= r...@foxi.me
> > Date: Wed, 15 Feb 2023 11:55:46 +0000
> > Subject: [PATCH] midipix platform support
> > MIME-Version: 1.0
> > Content-Type: text/plain; charset=UTF-8
> > Content-Transfer-Encoding: 8bit
> > 
> > Signed-off-by: Ørjan Malde r...@foxi.me
> > ---
> > configure.ac | 16 ++++++++++++++++
> > 1 file changed, 16 insertions(+)
> > 
> > diff --git a/configure.ac b/configure.ac
> > index 92536fb0..fa3d8cee 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -832,6 +832,22 @@ case "$host_os" in
> > LIBHOGWEED_LIBS='-Wl,--no-whole-archive $(LIBS) libnettle.dll.a'
> > IF_DLL=''
> > ;;
> > + midipix*)
> > + if test "x$ABI" = x64 ; then
> > + W64_ABI=yes
> > + fi
> > + LIBNETTLE_FORLINK=libnettle.so
> > + LIBNETTLE_SONAME='$(LIBNETTLE_FORLINK).$(LIBNETTLE_MAJOR)'
> > + LIBNETTLE_FILE='$(LIBNETTLE_SONAME).$(LIBNETTLE_MINOR)'
> > + LIBNETTLE_LINK='$(CC) $(CFLAGS) $(LDFLAGS) -shared 
> > -Wl,--out-dsolib=libnettle.lib.a -Wl,-soname=$(LIBNETTLE_SONAME)'
> > + LIBNETTLE_LIBS=''
> > +
> > + LIBHOGWEED_FORLINK=libhogweed.so
> > + LIBHOGWEED_SONAME='$(LIBHOGWEED_FORLINK).$(LIBHOGWEED_MAJOR)'
> > + LIBHOGWEED_FILE='$(LIBHOGWEED_SONAME).$(LIBHOGWEED_MINOR)'
> > + LIBHOGWEED_LINK='$(CC) $(CFLAGS) $(LDFLAGS) -shared 
> > -Wl,--out-dsolib=libhogweed.lib.a -Wl,-soname=$(LIBHOGWEED_SONAME)'
> > + LIBHOGWEED_LIBS='$(LIBS) .lib/libnettle.so.8'
> > + ;;
> > darwin*)
> > LIBNETTLE_FORLINK=libnettle.dylib
> > LIBNETTLE_SONAME='libnettle.$(LIBNETTLE_MAJOR).dylib'
> > --
> > 2.35.6
> > _______________________________________________
> > nettle-bugs mailing list -- nettle-bugs@lists.lysator.liu.se
> > To unsubscribe send an email to nettle-bugs-le...@lists.lysator.liu.se
> 
> 
> --
> Niels Möller. PGP key CB4962D070D77D7FCB8BA36271D8F1FF368C6677.
> Internet email is subject to wholesale government surveillance.
_______________________________________________
nettle-bugs mailing list -- nettle-bugs@lists.lysator.liu.se
To unsubscribe send an email to nettle-bugs-le...@lists.lysator.liu.se

Reply via email to