Jussi Kivilinna <jussi.kivili...@iki.fi> writes: > I ran into memory corruption issue when benchmarking new OCB code. > > I think "dst -= size;" in ocb_crypt_n() should be "dst += size;" ... > https://git.lysator.liu.se/nettle/nettle/-/blob/master/ocb.c#L240
Ooops. I think you're right. How large input sizes did you need to trigger problems? I just tried valgrind ./examples/nettle-benchmark ocb, which I would expect to call this function with about 10 KiB data at a time, but no crashes and no complaints from valgrind, which is puzzling. I'll need some more investigation to reproduce the problem. > Also it would be nice if ocb_aes128 could be added to nettle_aeads > array for easy access. Which combination(s) of nonce size and tag size would it be useful to advertise like that? Regards, /Niels -- Niels Möller. PGP key CB4962D070D77D7FCB8BA36271D8F1FF368C6677. Internet email is subject to wholesale government surveillance. _______________________________________________ nettle-bugs mailing list -- nettle-bugs@lists.lysator.liu.se To unsubscribe send an email to nettle-bugs-le...@lists.lysator.liu.se
