On Oct 18, 2011, at 13:32, Niels Möller wrote: > Ryan Schmidt writes: > >>> I've patched nettle in MacPorts to build proper Mac OS X dynamic >>> libraries, and wanted to share the patch with you. > > Thanks. One question: You add $(LIBS) to LIBNETTLE_LIBS (and to > LIBHOGWEED_LIBS). Why, and what do you expect $(LIBS) to contain? It > usually contains -lgmp (if configure finds the gmp library), which > shouldn't be needed by the dynamic nettle library, and which is included > explicitly in LIBHOGWEED_LIBS.
I expected $(LIBS) to be empty, but I added it for consistency with the mingw32 and cygwin cases. But it's not in the solaris or default cases so I don't know if that was correct. I figured somebody might want to pass in additional libs in the LIBS variable some day. It is listed in "./configure --help" as an "influential environment variable" so I wanted its influence to be respected in the event that it is used. >> Since your mailing list software appears to silently strip out attachments, > > Might depend on the content-type of the attachment. I'm not really > friends with mailman configuration. Sorry for the inconvenience. It's > also perfectly ok to post patches inline (unless perhaps if they're > really huge). I've seen mail programs and mailing list software strip leading whitespace which pretty much destroys patches pasted inline so I try to refrain from doing that. _______________________________________________ nettle-bugs mailing list [email protected] http://lists.lysator.liu.se/mailman/listinfo/nettle-bugs
