> From: [email protected] (Niels Möller)
> Cc: [email protected]
> Date: Sat, 07 Jan 2012 22:08:30 +0100
> 
> Thanks for testing. As Martin wrote, there has been some progress on
> windows support since the release. It would be great if you could test
> the cvs version (sorry it's a little cumbersome; you need to check out
> the lsh tree and follow the instructions on
> http://www.lysator.liu.se/~nisse/nettle/).

I will try that when I have time, if a new release is too far to wait
until then.

Doesn't building from CVS require additional tools, like Autoconf and
Automake?

> > Problem #3: Tests crash because they don't find libhogweed-2-1.dll.  This is
> > because Makefile uses "ln -sf" to create .lib/*.dll.
> 
> Not fixed. Using an LN_S make variable makes sense to me, but there
> should also be a corresponding configure check (hopefully there's some
> standard autoconf test?). Patch appreciated.

LN_S is a standard autoconf thing, so it should be easy.  Sorry, I
don't know about autoconf enough to send a patch.  However, by looking
at random configure scripts, I found that having this in configure.ac:

  AC_PROG_LN_S

is probably all you need.

> > Problem #8: examples/rsa-encrypt-test fails because rsa-encrypt.c and
> > rsa-decrypt.c read/write binary data from stdin to stdout, but do
> > not set these streams to binary mode.
> >
> >   To solve this, I added code to the test programs to use binary
> >   mode.  Let me know if you want me to submit patches for that.
> 
> These files now do
> 
> #ifdef WIN32
>   setmode(0, O_BINARY);
>   setmode(1, O_BINARY);
> #endif
> 
> Do you think this is a correct solution?

Yes, except that I would use _setmode, as that will also work for
Windows compilers other than MinGW.

Thanks.
_______________________________________________
nettle-bugs mailing list
[email protected]
http://lists.lysator.liu.se/mailman/listinfo/nettle-bugs

Reply via email to