Alon Bar-Lev <[email protected]> writes: Thanks. I have one comment on the patch.
> --- a/Makefile.in > +++ b/Makefile.in > @@ -21,7 +21,11 @@ include config.make > PRE_CPPFLAGS = -I. > # FIXME: Add configuration of LIBEXT? > LIBTARGETS = libnettle.a @IF_HOGWEED@ libhogweed.a > -SHLIBTARGETS = $(LIBNETTLE_FORLINK) @IF_HOGWEED@ $(LIBHOGWEED_FORLINK) > +@IF_STATIC@INSTALL_LIBTARGETS = install-static > +@IF_STATIC@UNINSTALL_LIBTARGETS = uninstall-static > +@IF_SHARED@SHLIBTARGETS = $(LIBNETTLE_FORLINK) @IF_HOGWEED@ > $(LIBHOGWEED_FORLINK) > +@IF_SHARED@INSTALL_SHLIBTARGETS = install-shared-nettle @IF_HOGWEED@ > install-shared-hogweed > +@IF_SHARED@UNINSTALL_SHLIBTARGETS = uninstall-shared I think I'd prefer to make the definitions unconditional, but with conditional values. E.g. UNINSTALL_SHLIBTARGETS = @IF_SHARED@ uninstall-shared rather than @IF_SHARED@UNINSTALL_SHLIBTARGETS = uninstall-shared Is there any reason that won't work? Regards, /Niels -- Niels Möller. PGP-encrypted email is preferred. Keyid C0B98E26. Internet email is subject to wholesale government surveillance. _______________________________________________ nettle-bugs mailing list [email protected] http://lists.lysator.liu.se/mailman/listinfo/nettle-bugs
