-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Aloha!
Niels Möller wrote: > 1. For the sha512.c copyright header, should it be "Copyright (C) > 2014 Joachim Strömbergson", or Secworks AB, or something else? Just add me (Joachim) as coauthor if that is ok with you. It is mainly your code. > 2. Test cases are needed. Benchmark support would also be nice, but > less important than tests and documentation. Yes. To both. I was thinking of doing benchmarking anyway since the point of these versions is to get better performance than for normal SHA-224 and SHA-256. > 3. I think there should be _DIGEST_SIZE and _DATA_SIZE defines for > the new algorithms. In particular, SHA512_256_DATA_SIZE is different > from SHA256_DATA_SIZE. Good point. I'll add those and file new patches. Probably today. > 4. Add corresponding -meta.c files? Defining > > const struct nettle_hash nettle_sha512_224; const struct nettle_hash > nettle_sha512_256; > > Or, since all variants are implemented in the same sha512.c source > file anyway, maybe these objects could be placed together in > sha384-meta.c. With this in place, adding them to > examples/nettle-benchmark.c is trivial. A little bit confusing having them in SHA-384. But something one should be able to live with. I'll do some hacking on this and the docs. - -- Med vänlig hälsning, Yours Joachim Strömbergson - Alltid i harmonisk svängning. ======================================================================== Joachim Strömbergson Secworks AB [email protected] ======================================================================== -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) Comment: GPGTools - http://gpgtools.org Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBCAAGBQJTK/tXAAoJEF3cfFQkIuyNn+QQAIpnRdl+bT+d5o7DAzmakH8c yVlycrkrD7kfvxDNBsJcFRdhN6+Y9X57D0gaHJST+H7ppDYWwKa4G5zmHt4FmJRI Lgq1I6gDzmY+9DJY4it2Cjm3kNQhFqTD+kvoE2q9sSYVovrER0SlPVjrr8D2YP6J 0mq66+S79IIS1mcYOZ/K0l8VlBEW2plT+VYGw/x3MdoLGzn0lVCFXelLtHIrtZcv KVF9/JPvK7B2pioZwu6majISjI3vM8XK+q5PxaRRy+QE6Xe9vft0DFw9/vJ9euvW DR9b9BY/6P97UssUqNPBy6Ur9MJFhOAeaJ1w+c+YRAozZnEIlBBxkiWBFZpZaIKU hpMpz53BvqjJti/W/VGydIReyGkmVVAfxRspGCkhYxWFrzueNxy/LRCrmo7AvnBY EY+aMux0gtfXlFdVjBUPELjyPc3ZYeNKaAeUlcyzDHnRJnGzhmb/8cf0EckEQ0xZ bF3D7FPmlPfiJ6TtQVzHzCcJ7JnzE1ZZ0OJlAJW3I3/JgNcV9XE4TZBoKHb0mrS6 kVy1JDn/8wDD5MDcmfgBPhp0l6L1JxKOOdY+/uLTxtEoEH6jTAIEFUVTbcYmj/3U LnOoLkIkDlD/LeOUlR3UY3fCIhu7PqkEQXEjVky0aFkLZPmzGzYI2CQfFRLkD1Xk P9ckLOOBMkBrxcejeG7f =/mvv -----END PGP SIGNATURE----- _______________________________________________ nettle-bugs mailing list [email protected] http://lists.lysator.liu.se/mailman/listinfo/nettle-bugs
