Amos Jeffries <[email protected]> writes:

> I have added a fuzz tester that runs a set of randomly generated strings
> past the default encoder and decoder, then the extended one.

Nice. It would be good with a couple of short manual examples as well. A
pity that RFC 4648 doesn't include any testvectors for base64url. (Or am
I missing something? Simon?)

>  - if you have a better random generator you would like to use please
> let me know where to find a code example or docs for it.

I'd suggest using lfib_knuth generator in nettle. And maybe you already
to that, but it's good to randomize also the length of the data.

> The test and the coders seem to be working fine. Except that when I
> increase the *count* of fuzz test run it asserts regular as clockwork on
> the 950th loop:
>
>  base64-test: base64-encode.c:96: _base64_encode_raw: Assertion `in ==
> src' failed.

This needs investigation. Have you run the tests under valgrind? ("make
check EMULATOR='$(VALGRIND)'")?

> Do you wish me to remove base64_encode_group entirely?

No, not at this time (it's used in one place, in the unfinished openpgp
code).

Regards,
/Niels


-- 
Niels Möller. PGP-encrypted email is preferred. Keyid C0B98E26.
Internet email is subject to wholesale government surveillance.
_______________________________________________
nettle-bugs mailing list
[email protected]
http://lists.lysator.liu.se/mailman/listinfo/nettle-bugs

Reply via email to