Martin Sebor <[email protected]> writes:

> One such file
> that comes into play in the failing tests is camellia-absorb.c.
> Since powerpc64le obviously does have such support, the code
> is unnecessary and, as it turns out, introduces errors.

I added an #include <limits.h> to camellia-absorb.c last June, after the
same problem had been tracked down by Magnus Holmgren, starting from
failing tests on the debian s390x build machines.

I should mention this bugfix in the NEWS file for 3.1.

If you have found any additional other file(s) which are missing a
required limits.h include, I'd like to know.

And the primary problem is not a bad value of HAVE_NATIVE_64_BIT in
itself (that should only affect performance). What really breaks
camellia is that HAVE_NATIVE_64_BIT is evaluated differently in
cammellia-absorb.c and camellia-crypt-internal.c, since the subkeys are
processed slightly differently in the two cases.

The special case for x86_64 in config.h is intended only for 64-bit MS
windows builds. At least, that's the only 64-bit system I'm aware of
where unsigned long is not a 64-bit type.

Regards,
/Niels

-- 
Niels Möller. PGP-encrypted email is preferred. Keyid C0B98E26.
Internet email is subject to wholesale government surveillance.
_______________________________________________
nettle-bugs mailing list
[email protected]
http://lists.lysator.liu.se/mailman/listinfo/nettle-bugs

Reply via email to