Nikos Mavrogiannopoulos <[email protected]> writes:

> I went this path, and now there is a version.h which defines,
> NETTLE_VERSION (combo), NETTLE_VERSION_MAJOR and NETTLE_VERSION_MINOR.

Thanks.

> --- /dev/null
> +++ b/version.h.in
...
> +#ifndef NETTLE_VERSION_H_INCLUDED
> +#define NETTLE_VERSION_H_INCLUDED
> +
> +#include "nettle-types.h"

Why this include?

> +/* The combined version in hex */
> +#define NETTLE_VERSION @NUMBER_VERSION@

Any motivation for this particular grouping, and the corresponding

  AC_SUBST([NUMBER_VERSION], `printf "0x%02x%02x" $MAJOR_VERSION 
$MINOR_VERSION`)

Is it a common convention with other libraries? Is there some reason it
has to be a hex literal, and not just constructed as

  #define NETTLE_VERSION (((NETTLE_VERSION_MAJOR) << 8) | 
(NETTLE_VERSION_MINOR))

which should produce the same integer? My gut feeling is still that it
is better to leave the construction of a combined version number to the
applications that need it.

Regards,
/Niels

-- 
Niels Möller. PGP-encrypted email is preferred. Keyid C0B98E26.
Internet email is subject to wholesale government surveillance.
_______________________________________________
nettle-bugs mailing list
[email protected]
http://lists.lysator.liu.se/mailman/listinfo/nettle-bugs

Reply via email to