Nikos Mavrogiannopoulos <[email protected]> writes: > The attached patches add a static analyzer run in the nettle CI and > fix few minor issues found with it. > > There two issues I didn't fix because I am not sure whether it is a > logical error or an initialization of the variables in question could > solve it. I attach the html output of scan-view. Both involve the > ecc_mod() function and the variable 'hi'.
That and patch 0002 below deserves a closer look (it's not obvious that the return value shouldn't be used). The other three fixes applied now. > [2. text/x-patch; 0004-hogweed-benchmark-eliminated-memory-leak.patch]... > > [3. text/x-patch; > 0003-_aes_set_key-ensure-with-assert-that-nk-is-non-zero.patch]... > > [4. text/x-patch; 0002-ecc_mod_inv-eliminated-dead-increment.patch]... > > [5. text/x-patch; 0001-.gitlab-ci.yml-added-static-analyzers-run.patch]... Regards, /Niels -- Niels Möller. PGP-encrypted email is preferred. Keyid 368C6677. Internet email is subject to wholesale government surveillance. _______________________________________________ nettle-bugs mailing list [email protected] http://lists.lysator.liu.se/mailman/listinfo/nettle-bugs
