Tim Rühsen <[email protected]> writes: > #defines should not start with an underscore. C standards say this is > reserved (for system headers !?) and some static analyzers complain > about it.
Note that Nettle has violated this rule since the very beginnings. E.g, #define _MD5_DIGEST_LENGTH 4 has been in md5.h since the initial commit (back in April 2001, around midnight). I haven't seen any reports about this causing problems. I agree it's not quite right, and maybe we should clean this up at some point, replacing the leading underscore by nettle_internal_ (or maybe trailing underscore or nettle__ (double underscore). But not now. Which static analyzers complain? Regards, /Niels -- Niels Möller. PGP-encrypted email is preferred. Keyid 368C6677. Internet email is subject to wholesale government surveillance. _______________________________________________ nettle-bugs mailing list [email protected] http://lists.lysator.liu.se/mailman/listinfo/nettle-bugs
