Simo Sorce <[email protected]> writes: > Ok attached find new patches, > they address all concerns except for adding the CET_SECTION macro > automagically to all asm files.
Ah, one more thing: > +define(<GNU_CET_SECTION>, > +<ifelse(CET_PROTECTION,yes, > +<.pushsection .note.gnu.property,"a" How portable is .pushsection? If we ensure that notes are last, plain .section should be enough, I think. > --- a/x86_64/sha3-permute.asm > +++ b/x86_64/sha3-permute.asm > @@ -107,6 +107,7 @@ define(<ROTL64>, < > > C sha3_permute(struct sha3_state *ctx) > .text > +GNU_CET_SECTION() > ALIGN(16) > PROLOGUE(nettle_sha3_permute) > W64_ENTRY(1, 16) This placement between .text and the prologue depends on .pushsection / .popsection. I think it should be moved last, just like in the other files, either explicitly or by means of a divert in some of the included m4 files. Regards, /Niels -- Niels Möller. PGP-encrypted email is preferred. Keyid 368C6677. Internet email is subject to wholesale government surveillance. _______________________________________________ nettle-bugs mailing list [email protected] http://lists.lysator.liu.se/mailman/listinfo/nettle-bugs
