[email protected] writes:
> From: Dmitry Eremin-Solenikov <[email protected]>
>
> Add common implementations for functions doing XOR over
> nettle_block16/nettle_block8.
I've merged the first two patches. Thanks! Do you know if anyone is using
GCM_TABLE_BITS 4? I've tested that it still works, both before and after
your change, but I don't test it regularly.
> +static inline void
> +block16_xor_bytes (union nettle_block16 *r,
> + const union nettle_block16 *x,
> + const uint8_t *bytes)
> +{
> + memxor3 (r->b, x->b, bytes, 16);
> +}
[...]
> +static inline void
> +block8_xor_bytes (union nettle_block8 *r,
> + const union nettle_block8 *x,
> + const uint8_t *bytes)
> +{
> + memxor3 (r->b, x->b, bytes, 8);
> +}
Not sure these two wrappers are that helpful. Do you have a good
reason to add them?
The rest of the patch looks like a nice consolidation.
> --- a/gcm.c
> +++ b/gcm.c
> @@ -53,16 +53,10 @@
> #include "nettle-internal.h"
> #include "macros.h"
> #include "ctr-internal.h"
> +#include "block-internal.h"
>
> #define GHASH_POLYNOMIAL 0xE1UL
>
> -static void
> -gcm_gf_add (union nettle_block16 *r,
> - const union nettle_block16 *x, const union nettle_block16 *y)
> -{
> - r->u64[0] = x->u64[0] ^ y->u64[0];
> - r->u64[1] = x->u64[1] ^ y->u64[1];
> -}
> /* Multiplication by 010...0; a big-endian shift right. If the bit
> shifted out is one, the defining polynomial is added to cancel it
> out. r == x is allowed. */
> @@ -108,7 +102,7 @@ gcm_gf_mul (union nettle_block16 *x, const union
> nettle_block16 *y)
> for (j = 0; j < 8; j++, b <<= 1)
> {
> if (b & 0x80)
> - gcm_gf_add(&Z, &Z, &V);
> + block16_xor3(&Z, &Z, &V);
This and few other calls below can be block16_xor rather than block16_xor3.
Regards,
/Niels
--
Niels Möller. PGP-encrypted email is preferred. Keyid 368C6677.
Internet email is subject to wholesale government surveillance.
_______________________________________________
nettle-bugs mailing list
[email protected]
http://lists.lysator.liu.se/mailman/listinfo/nettle-bugs
