Daiki Ueno <[email protected]> writes: > From: Daiki Ueno <[email protected]> > > The changes from the previous series are: > - remove the global hmac_*_set_key_expanded functions > - leave out set_nonce member if the operation is not supported > > For the latter, I was wondering whether it is better to define a no-op > set_nonce, but given the fact that that the caller nevertheless checks > nonce_size, I chose to make the field blank.
I'm a bit uneasy about the set_nonce pointer. It's used only for umac, where nonce use is a bit peculiar with the auto-increment optimization. Would it be ok to leave umac out, and move the definition of nettle_mac from testutils.h as is (except that the comment "other sizes are sometimes possible" on the key_size field seems wrong)? Then nettle_mac is very similar to nettle_hash, one just calls ->set_key instead of ->init, and one can then hash several messages with the same key using a sequence of ->update and ->digest calls. Regards, /Niels -- Niels Möller. PGP-encrypted email is preferred. Keyid 368C6677. Internet email is subject to wholesale government surveillance. _______________________________________________ nettle-bugs mailing list [email protected] http://lists.lysator.liu.se/mailman/listinfo/nettle-bugs
