Simo Sorce <[email protected]> writes: > On Thu, 2020-03-12 at 21:53 +0100, Niels Möller wrote: >> But I'm a bit confused by the use of ASM_X86_ENDBR. The instruction is >> added to entry points, via the PROLOGUE macro, but not to other branch >> targets, e.g., loop labels in the assembly files. Is that not needed >> (because branches are direct, without going via PLT indirection)? Or >> will the assembler insert some ENDBR instructions automatically? > > ENDBR is only needed at CALL targets or indirect jump targets, so not > needed for direct call. Actually theoretical harmful to add any ENDBR > you do not need, as you give more landing sites.
Thanks for the explanation. Patch merged to master now. Regards, /Niels -- Niels Möller. PGP-encrypted email is preferred. Keyid 368C6677. Internet email is subject to wholesale government surveillance. _______________________________________________ nettle-bugs mailing list [email protected] http://lists.lysator.liu.se/mailman/listinfo/nettle-bugs
