On Sun, Jan 31, 2021 at 10:35 AM Niels Möller <[email protected]> wrote:
> > --- /dev/null > > +++ b/arm64/v8/gcm-hash.asm > > @@ -0,0 +1,343 @@ > > > +C common macros: > > +.macro PMUL in, param1, param2 > > + pmull F.1q,\param2\().1d,\in\().1d > > + pmull2 F1.1q,\param2\().2d,\in\().2d > > + pmull R.1q,\param1\().1d,\in\().1d > > + pmull2 R1.1q,\param1\().2d,\in\().2d > > + eor F.16b,F.16b,F1.16b > > + eor R.16b,R.16b,R1.16b > > +.endm > > For consistency, I'd prefer defining all needed macros using m4. > The macros in gcm-hash.asm file are dependent on defines in the same file (shared for macros and function implementation) as they are relevant with the implementation context, also moving those macros to another file makes confusion for reader IMO. regards, Mamone _______________________________________________ nettle-bugs mailing list [email protected] http://lists.lysator.liu.se/mailman/listinfo/nettle-bugs
