Jeffrey Walton <[email protected]> writes:

> This is building Nettle 3.7.2 on a PowerMac with OS X 10.5:
>
> /usr/bin/cc -I. -I/usr/local/include -DNDEBUG -DHAVE_CONFIG_H -g2 -O2
> -mlong-double-64 -fno-common -maltivec -fPIC -pthread -ggdb3
> -Wno-pointer-sign -Wall -W   -Wmissing-prototypes
> -Wmissing-declarations -Wstrict-prototypes   -Wpointer-arith
> -Wbad-function-cast -Wnested-externs -fPIC -MT xts-aes128.o -MD -MP
> -MF xts-aes128.o.d -c xts-aes128.c \
>         && true
> xts.c: In function ‘xts_shift’:
> xts.c:59: warning: integer constant is too large for ‘long’ type
> xts.c:59: warning: integer constant is too large for ‘long’ type
> xts.c:60: warning: integer constant is too large for ‘long’ type
> xts.c:60: warning: integer constant is too large for ‘long’ type
> xts.c:60: warning: integer constant is too large for ‘long’ type
>
> On OS X 10.5, you have to use unsigned long long and the ull suffix.

This is confusing. The xts_shift function is not in nettle-3.7.2, as far
as I can tell, it was deleted long ago in
https://git.lysator.liu.se/nettle/nettle/-/commit/685cc919a37b60d3f81dd569bf6e93ad7be0f89b.

> Maybe you should add a configure test to see whether you need the ull suffix.

The current related code uses UINT64_C for the 64-bit constants. No
configure test needed.

Regards,
/Niels

-- 
Niels Möller. PGP-encrypted email is preferred. Keyid 368C6677.
Internet email is subject to wholesale government surveillance.
_______________________________________________
nettle-bugs mailing list
[email protected]
http://lists.lysator.liu.se/mailman/listinfo/nettle-bugs

Reply via email to