I've added a new comment that wipes hash subkey from stack once GHASH operation completed as it's a good practice to do so, I also added a disassembly snippet in the comment section that proves the need of reserving 160 bytes before committing a dynamic stack allocation.
regards, Mamone On Thu, Jul 1, 2021 at 4:43 PM Maamoun TK <[email protected]> wrote: > I've replied to your comments in the MR. > > Thank you, > Mamone > > On Wed, Jun 30, 2021 at 10:10 PM Niels Möller <[email protected]> > wrote: > >> Maamoun TK <[email protected]> writes: >> >> > I made a merge request !26 >> > <https://git.lysator.liu.se/nettle/nettle/-/merge_requests/26> that >> > optimizes the GHASH algorithm for S390x architecture. >> >> Nice! I've added a few comments in the mr. >> >> Regards, >> /Niels >> >> -- >> Niels Möller. PGP-encrypted email is preferred. Keyid 368C6677. >> Internet email is subject to wholesale government surveillance. >> > _______________________________________________ nettle-bugs mailing list [email protected] http://lists.lysator.liu.se/mailman/listinfo/nettle-bugs
