Amitay Isaacs <[email protected]> writes:

> diff --git a/powerpc64/ecc-secp384r1-modp.asm 
> b/powerpc64/ecc-secp384r1-modp.asm
> new file mode 100644
> index 00000000..67791f09
> --- /dev/null
> +++ b/powerpc64/ecc-secp384r1-modp.asm
> @@ -0,0 +1,227 @@
> +C powerpc64/ecc-secp384r1-modp.asm

This looks nice (and it seems folding scheme is the same as for
the x86_64 version). Just one minor thing,

> +define(`FUNC_ALIGN', `5')
> +PROLOGUE(_nettle_ecc_secp384r1_modp)
> +
> +     std     H0, -48(SP)
> +     std     H1, -40(SP)
> +     std     H2, -32(SP)
> +     std     H3, -24(SP)
> +     std     H4, -16(SP)
> +     std     H5, -8(SP)

I find it clearer to use register names rather than the m4 defines for
save and restore of callee-save registers.

Regards,
/Niels

-- 
Niels Möller. PGP key CB4962D070D77D7FCB8BA36271D8F1FF368C6677.
Internet email is subject to wholesale government surveillance.
_______________________________________________
nettle-bugs mailing list
[email protected]
http://lists.lysator.liu.se/mailman/listinfo/nettle-bugs

Reply via email to