On Tue, Jun 28, 2022 at 5:10 PM Niels Möller <[email protected]> wrote:
> Maamoun TK <[email protected]> writes: > > > Apparently, 'clgije/risbg' instructions have been added in arch8 (z10) by > > General-instructions-extension facility (GIEF) according to > "z/Architecture > > Principles of Operation". > > How old is arch8/z10? Do you see any need to support older hardware? > Old enough to not consider maintaining it. However, the issue here is to make the assembler aware of the minimum targeted machine so it recognizes instruction mnemonics. Forcing instruction opcodes could've been an option to resolve the issue but explicitly declaring machine type is a more proper fix in this case. > > I've pushed a potential fix into my branch of > > repository that alters assembler of machine type in memxor.s which is > > supposed to address the mentioned issue > > https://git.lysator.liu.se/mamonet/nettle/-/tree/s390x-gief-fix > > It would be nice if you could try it out and check if the build process > > proceeds so I can make a merge request for that change. > > So adding the pseudo op > > .machine "z10" > > tells the assembler to recognize the instructions (similar to .machine > "z13" in some other s390x files). > Right. It's really baffling me what kind of circumstances GAS triggers these sorts of Unrecognized opcode errors as I couldn't reproduce the current issue in my own setup. Anyway, feeding minimum machine architecture into assembler has no downsides and should serve as a sidestep for these kinds of errors. regards, Maamoun I've merged your change, with a minor edit of commit message. > > Regards, > /Niels > > -- > Niels Möller. PGP key CB4962D070D77D7FCB8BA36271D8F1FF368C6677. > Internet email is subject to wholesale government surveillance. > _______________________________________________ nettle-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
