Maamoun TK <[email protected]> writes: > Merging Poly1305 implementation that utilizes 'vmsumudm' instruction > https://git.lysator.liu.se/nettle/nettle/-/merge_requests/47 into the > upstream triggers false failure in Gitlab CI. Running the patch natively > passes all tests successfully, I've tracked down the issue to observe a bug > in qemu that produces wrong output of 'vmsumudm' instruction. I opened an > issue in qemu repository with the bug description > https://gitlab.com/qemu-project/qemu/-/issues/1156
Looks like it shouldn't be too difficult to fix in qemu (from that bug report, relevant code is https://gitlab.com/qemu-project/qemu/-/blob/master/target/ppc/translate/vmx-impl.c.inc#L2988). Do I understand that code correctly, that qemu never reads the third "vrc" input to the instruction? Thanks for tracking it down. > Even if we would get the bug fixed shortly, we still need to update the > machine images of CI testing or executing pipeline configuration commands > to reflect the upstream state of qemu repository which needs some time to > have that done. I'd suggest to disable power9 code testing in CI for now > since it only has the poly1305 code which passed tests natively. I've pushed a workaround to the master-updates branch, see https://git.lysator.liu.se/nettle/nettle/-/commit/d618864183ccfdcd0d1b5443111fbaf9a5934517 Regards, /Niels -- Niels Möller. PGP key CB4962D070D77D7FCB8BA36271D8F1FF368C6677. Internet email is subject to wholesale government surveillance. _______________________________________________ nettle-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
