Gisle Vanem <[email protected]> writes: > But I noted it's .asm-code says 'W64_ENTRY(3, 0)' > Why not 'W64_ENTRY(4, 0)' when there are 4 arguments? > > I admin 'm4' is alien to me, but changing it into: > > --- a/x86_64/sha256-compress-n.asm 2023-02-13 07:38:45 > +++ b/x86_64/sha256-compress-n.asm 2023-02-14 14:04:26 > @@ -134,7 +134,7 @@ > ALIGN(16) > > PROLOGUE(_nettle_sha256_compress_n) > - W64_ENTRY(3, 0) > + W64_ENTRY(4, 0) > test BLOCKS, BLOCKS > jz .Lend > > @@ -228,6 +228,6 @@ > add $120, %rsp > .Lend: > mov INPUT, %rax > - W64_EXIT(3, 0) > + W64_EXIT(4, 0) > ret > EPILOGUE(_nettle_sha256_compress_n)
I've committed this fix. Thanks! > But in other places I see 'W64_ENTRY(x..)' is > used for functions with 'y' arguments (y != x). > Somebody please explain this. I've found a few places where it looked like W64_ENTRY was used correctly, but nearby comments were wrong. Committed those comment fixes too. Do you still see any W64_ENTRY that you think is wrong? Regards, /Niels -- Niels Möller. PGP key CB4962D070D77D7FCB8BA36271D8F1FF368C6677. Internet email is subject to wholesale government surveillance. _______________________________________________ nettle-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
