Hi Niels, My fault. I did not include the gym-aes-crypt.c in the patch. Here is the updated patch. Please apply this one and we can work from there.
Thanks. -Danny > On Mar 5, 2024, at 1:08 PM, Niels Möller <[email protected]> wrote: > > Danny Tsen <[email protected]> writes: > >> Please let me know when you merge the code and we can work from there. > > Hi, I tried to apply and build with the v5 patch, and noticed some problems. > > Declaration of _gcm_aes_encrypt / _gcm_aes_decrypt is missing. It can go > in gcm-internal.h, like on this branch, > https://git.lysator.liu.se/nettle/nettle/-/blob/x86_64-gcm-aes/gcm-internal.h?ref_type=heads > Corresponding name mangling defines should also be in gcm-internal.h, > not in the installed gcm.h header. > > The file gcm-aes.c was missing in the patch. If the dummy C versions of > _gcm_aes_*crypt are needed only for fat builds, maybe simplest to put the > definitions in fat-ppc.c (maybe one can even use the same "return 0" dummy > function for both encrypt and decrypt). > > It would also be nice if you could check that the new code is used > and working in a non-fat build, configured with --disable-fat > --enable-power-crypto-ext. > > Regards, > /Niels > > -- > Niels Möller. PGP key CB4962D070D77D7FCB8BA36271D8F1FF368C6677. > Internet email is subject to wholesale government surveillance. _______________________________________________ nettle-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected]
