Nice!

Let me know if you have any other questions

> Am 01.07.2016 um 20:15 schrieb Chris Conroy <[email protected]>:
> 
> Ah. Yep that appears to do the trick!
> 
> It does appear this is a case of the server writing too fast for the client. 
> I should be able to address this by utilizing the channel high/low watermarks.
> 
>> On Fri, Jul 1, 2016 at 12:45 AM, 'Norman Maurer' via Netty discussions 
>> <[email protected]> wrote:
>> If its a ServerBootstrap you need to use childOption(...) to specify the 
>> allocator for the accepted Channels. Using option(...) will set it for the 
>> ServerChannel which is not what you want here.
>> 
>>> Am 30.06.2016 um 23:14 schrieb Chris Conroy <[email protected]>:
>>> 
>>> I have encountered a strange issue in some server code on top of Netty 4.1 
>>> Final using the Java SSL server engine.
>>> 
>>> When I try to send a very large file through the pipeline, I get an 
>>> OutOfDirectMemoryError from an Sslhandler#flush.
>>> 
>>> Of course, this could happen if I failed to call release somewhere in the 
>>> pipeline, but we’re actually setting .option(ChannelOption.ALLOCATOR, new 
>>> UnpooledByteBufAllocator(false)) in the bootstrap for this server in order 
>>> to get Netty 3-like memory semantics. (We plan to shift to the pooled 
>>> allocator later after shaking out any other Netty 4 issues).
>>> 
>>> The fact that the SslHandler is still using a direct buffer pool despite 
>>> the option above seems like a bug. Or, am I misunderstanding this option?
>>> 
>>> If things were generally leaking, I would expect to see this eventually 
>>> even without large requests, but it seems to only impact channels that are 
>>> servicing a large transfer. I’m still gathering more data on the issue, but 
>>> FWIW the leak detector in advanced mode has not reported any leaks, and 
>>> interestingly I cannot reproduce the issue when running under paranoid mode.
>>> 
>>> io.netty.util.internal.OutOfDirectMemoryError: failed to allocate 16777216 
>>> byte(s) of direct memory (used: 4110417927, max: 4127195136)
>>>         at 
>>> io.netty.util.internal.PlatformDependent.incrementMemoryCounter(PlatformDependent.java:592)
>>>         at 
>>> io.netty.util.internal.PlatformDependent.allocateDirectNoCleaner(PlatformDependent.java:546)
>>>         at 
>>> io.netty.buffer.PoolArena$DirectArena.allocateDirect(PoolArena.java:699)
>>>         at 
>>> io.netty.buffer.PoolArena$DirectArena.newChunk(PoolArena.java:688)
>>>         at io.netty.buffer.PoolArena.allocateNormal(PoolArena.java:237)
>>>         at io.netty.buffer.PoolArena.allocate(PoolArena.java:221)
>>>         at io.netty.buffer.PoolArena.allocate(PoolArena.java:141)
>>>         at 
>>> io.netty.buffer.PooledByteBufAllocator.newDirectBuffer(PooledByteBufAllocator.java:262)
>>>         at 
>>> io.netty.buffer.AbstractByteBufAllocator.directBuffer(AbstractByteBufAllocator.java:179)
>>>         at 
>>> io.netty.buffer.AbstractByteBufAllocator.directBuffer(AbstractByteBufAllocator.java:170)
>>>         at 
>>> io.netty.buffer.AbstractByteBufAllocator.buffer(AbstractByteBufAllocator.java:107)
>>>         at io.netty.handler.ssl.SslHandler.allocate(SslHandler.java:1461)
>>>         at 
>>> io.netty.handler.ssl.SslHandler.allocateOutNetBuf(SslHandler.java:1471)
>>>         at io.netty.handler.ssl.SslHandler.wrap(SslHandler.java:523)
>>>         at io.netty.handler.ssl.SslHandler.flush(SslHandler.java:501)
>>>         at 
>>> io.netty.channel.AbstractChannelHandlerContext.invokeFlush0(AbstractChannelHandlerContext.java:762)
>>>         at 
>>> io.netty.channel.AbstractChannelHandlerContext.invokeFlush(AbstractChannelHandlerContext.java:754)
>>>         at 
>>> io.netty.channel.AbstractChannelHandlerContext.flush(AbstractChannelHandlerContext.java:735)
>>>         at 
>>> io.netty.channel.CombinedChannelDuplexHandler$DelegatingChannelHandlerContext.flush(CombinedChannelDuplexHandler.java:523)
>>>         at 
>>> io.netty.channel.ChannelOutboundHandlerAdapter.flush(ChannelOutboundHandlerAdapter.java:115)
>>>         at 
>>> io.netty.channel.CombinedChannelDuplexHandler.flush(CombinedChannelDuplexHandler.java:348)
>>>         at 
>>> io.netty.channel.AbstractChannelHandlerContext.invokeFlush0(AbstractChannelHandlerContext.java:762)
>>>         at 
>>> io.netty.channel.AbstractChannelHandlerContext.invokeFlush(AbstractChannelHandlerContext.java:754)
>>>         at 
>>> io.netty.channel.AbstractChannelHandlerContext.flush(AbstractChannelHandlerContext.java:735)
>>>         at 
>>> io.netty.channel.ChannelOutboundHandlerAdapter.flush(ChannelOutboundHandlerAdapter.java:115)
>>> ....
>>> -- 
>>> You received this message because you are subscribed to the Google Groups 
>>> "Netty discussions" group.
>>> To unsubscribe from this group and stop receiving emails from it, send an 
>>> email to [email protected].
>>> To view this discussion on the web visit 
>>> https://groups.google.com/d/msgid/netty/CA%2B%3DgZKAr-JCgHSW%3DFmNUEX6sXatXVQQcPanX44a%2BxQhaTMNUQw%40mail.gmail.com.
>>> For more options, visit https://groups.google.com/d/optout.
>> 
>> -- 
>> You received this message because you are subscribed to a topic in the 
>> Google Groups "Netty discussions" group.
>> To unsubscribe from this topic, visit 
>> https://groups.google.com/d/topic/netty/qL7MeOicyCE/unsubscribe.
>> To unsubscribe from this group and all its topics, send an email to 
>> [email protected].
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/netty/5B4F5055-BCB0-46B5-8EF4-73825152CA41%40googlemail.com.
>> For more options, visit https://groups.google.com/d/optout.
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Netty discussions" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to [email protected].
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/netty/CA%2B%3DgZKC%3D%2BnWMQqU8stEKuOKkf8fBRq2d_ho%2BJ2digp4bhDBSfA%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.

-- 
You received this message because you are subscribed to the Google Groups 
"Netty discussions" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/netty/C6EF052F-24A6-4B03-B6A4-78711C6CF9DF%40googlemail.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to