Hi,

I have question regarding the proper handling of HTTP requests.

I have the following pipeline:

channelPipeline.addLast(new HttpRequestDecoder());

//...

channelPipeline.addLast(new HttpObjectAggregator(maxRequestBodySizeInBytes));
//...
channelPipeline.addLast(new HttpDecoderResultValidator(httpProcessingMetrics));


In the result validator: 
I have the following check:

if (!request.decoderResult().isSuccess()) {



In that case, should I also call ReferenceCountUtil.release(msg);


If so, why? If not, why? 

I saw a fix 
<https://github.com/reactor/reactor-netty/commit/c7c9132813f82c895c13e96a6e0ad98e809063a6#diff-64beebed201b927e3ee7b2fa8c48d0b1>
 in reactor-http project which led to think about it.

Without it there will be a memory leak?


Thanks!

Asaf

-- 
You received this message because you are subscribed to the Google Groups 
"Netty discussions" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/netty/3e87527a-14e4-45dd-ac6a-34db329e33d0%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to