On Mon, Jan 30, 2006 at 01:19:27AM -0800, Darren Reed wrote: > > Reading through ip.c, time and again I find myself wonder "haven't I just > seen this block of code?" due to the prevalence of similar code blocks > repeated.
Yes, you've noticed only now? :) > A good example is the seemingly endless number of loops dealing with > multirouting IREs and another is the duplication of "is this an ipsec > packet, if so call something special". > > Is anyone working on refactoring the code to address some of these issues? The IPsec team has an unfunded project to get rid of remaining STREAMS infrastucture related to IPsec (we were waiting for FireEngine, plus we do have other fish to fry). I believe Surya will lay the groundwork for a LOT of potential crap-removal by allowing someone to kill most of ip_newroute(). Dan _______________________________________________ networking-discuss mailing list [email protected]
