> Reading through ip.c, time and again I find myself wonder "haven't I > just seen this block of code?" due to the prevalence of similar code > blocks repeated. > > A good example is the seemingly endless number of loops dealing with > multirouting IREs and another is the duplication of "is this an ipsec > packet, if so call something special".
BTW, a fair amount of IP complexity is being hauled out as part of the IPMP rearchitecture. Specifically, gutting the existing IPMP implementation netted 7800 lines of hairy IP kernel code, including 28% of ip_if.c[1]. While the new implementation will of course occupy some space, it stands to be considerably simpler, especially because addresses will no longer migrate (which allows all of the interface index games and ipsq merging/splitting logic to be removed). Of course, we're a long way from putback, so I'm not going to promise miracles just yet ;-) [1] http://atlantic.east/ws/meem/ipmp-cv/webrev/ -- meem _______________________________________________ networking-discuss mailing list [email protected]
