Sebastien Roy wrote:
Darren Reed wrote:
...
Can these be implemented as seperate kernel modules in Solaris?
Yes.
I'd encourage the document to talk about how to do this.
For example, talk about what type of module is best here (character
device, STREAMS, etc), what they should do in entry points, exit points,
what interfaces they need to implement and so on.
Maybe documenting how to use it like this is a seperate document, but if
I'm a 3rd party wanting to build a new tunneling device on top of this
frame work, just having this document doesn't appear to be what I want.
It talks a lot about changes and additions here and there, not so much
about what I need to do to develop a new MAC type.
...
As I read it, you're introducing an API for you to use but nobody
else, so I ask what is the point of it being a documented API?
The API won't be documented. The design document contains these
details because it's part of the design of this project.
It is sounding to me like it is an implementation detail rather than
part of the design.
If there is nothing in it being exported then I'm not sure I see the
point of documenting it here at all. Maybe as an annex to the design
doc, but definately not in the body.
If the API in section 6 isn't part of the deliverables, why not just
remove the section?
I'd rather see more effort and focus put into external APIs that anyone
can use and build upon.
...
Given how trivial IP in IP should be,
Yes, it should be. With the previous STREAMS based implementation, it
was far from trivial (have you seen tun.c?). Clearview will hopefully
allow the implementation to look as trivial as it should be.
My time with my therapist is limited, so I haven't yet gone to look at
tun.c :)
is it worthwhile demonstrating with source code how to build such a
tunneling device driver is?
Code should be the output of implementing this design, so I sure hope
I'll have some for you in the near future. :-|
This maybe a completely seperate document, but the idea is heavily
commented source code so that others can understand what's required
to build a working tunnel driver to work against this project and
where they should start hacking if they want to "change something",
like the encapsulation.
Sure, I'm all for well-documented code.
Cool!
Darren
_______________________________________________
networking-discuss mailing list
[email protected]
