>      mtp = portp->lp_txinfo;
 > -    mtp->mt_fn(mtp->mt_arg, mp);
 > +    if ((void*)mtp->mt_fn == (void*)mac_txloop)
 > +            /* TODO: replace NULL with caller's dls_link_t* */
 > +            ((mac_tx_lo_t)mtp->mt_fn)(mtp->mt_arg, mp, NULL);
 > +    else
 > +            mtp->mt_fn(mtp->mt_arg, mp);

Egad!  Having a pointer-to-function sometimes be called with a different
function signature is dreadful.

I believe Dong-Hai Han is working on a fix to the DLPI packet loopback
issue, along with several other related issues.  I've CC'd him on this
email.

--
meem
_______________________________________________
networking-discuss mailing list
[email protected]

Reply via email to