Kacheong Poon wrote:
Dave Miner wrote:

Why should it be that way?  What if I'd like to just get a particular
parameter from a particular offer, e.g.:

dhcpinfo -i bge0 -o 2 Router


Are you also suggesting to have a "get the number of offers"
option?  A user probably won't do a "-o 2" unless it is known
that the index number 2 makes sense.  But if a user already
knows that index number 2 makes sense, I guess he already gets
all the offers already.


Yes, you probably would need that as well.

And is it really useful to get a field from a specific offer
without knowing the other fields in that offer?  I assume one
also wants to associate an offer with the particular DHCP server.
And if a user wants to compare, say all the routers, I guess
a better syntax is


Is it ever useful to obtain one field from an ack without obtaining others? I think the answer is of course yes, and I believe that the same can be said for offers.

dhcpinfo -i <foo0> -o Router

Then it will print out the router fields from all offers.  Anyway,
all these do not affect the proposed DHCP_GET_ALL_TAG request.
The above can just be filtering done in dhcpinfo.


What if the point is not to compare a particular field across all, but just to look at one field on a specific one?

I agree it doesn't have to affect what is sent over the IPC channel between dhcpinfo and dhcpagent, but maximizing the usefulness of what dhcpinfo can present is a different question.


To me, the "get all" operation is orthogonal to the "get it from a
particular offer instead of an ack" selection.


The -o option implies all already.


Why does it have to? I realize you've asserted in the past that a caller can just parse through and find what they need, but I'm still underwhelmed with that answer, and so far you haven't offered any details on what the output format might be to allow that to be done. This scheme seems to address one very specific use case and ignore all other possibilities.


That seems to be an unnecessary change.  Why do I now need to use "-a"
to get it from the ack?  That will break any existing scripts, which
already expect to use the existing syntax.


There is a misunderstanding.  There is no change of current
dhcpinfo usage.  The -a option indicates that all info from
DHCPACK is returned.  With -o, all the offers are always returned.
There is no need for -a.


Which just seems to make for a very limited, and confusing, usage model.

Dave
_______________________________________________
networking-discuss mailing list
[email protected]

Reply via email to