Cyril Plisko wrote:
On 5/26/07, Garrett D'Amore <[EMAIL PROTECTED]> wrote:
I have decided to post a webrev for my mxfe driver, and I would like to
get folks to review it. This driver is for Macronix PMAC, and Lite-On
PNIC-II chips. They aren't terribly common, but the Linksys v2 cards
were a PNIC-II. (I have three NIC supported by this driver, a Linksys
LNE-100TX v2, a Kingston KNE-111TX, and an evaluation board that
Macronix gave me a few years ago.)
The webrev is at
http://cr.opensolaris.org/~gdamore/mxfe/
This is a GLDv3 driver, which means it is useful for VLANs (I've
verified that it works with VLANs all the way up to full MTU frames),
and it works with IP instances. Which is incredibly useful. (IP
instances with IPsec was the killer application that caused me to do the
work to update this driver to GLDv3.)
If someone wants this on S10, we could do a backport, but it would have
to altered to use the previous generation of the GLDv3.
Anyway I'd appreciate reviews, and I'll probably commit this to ON once
I get enough reviews and approval from whatever committees are present.
Garret,
just curious, why don't you use new style interrupt framework
(ddi_intr_*) ?
I mean I guess you wrote the driver some time ago, presumably before
the ddi_intr_* framework was introduced, but this work is a new bits
being integrated into ON. Do you think it would worth it to rewrite it
to the
new framework ?
Short answer: no.
Long answer: Yes I wrote it a long time ago. Updating it to the new
ddi_intr framework would be nice, but this chip will never be on a PCI
express bus, will never support MSI, and, in short, will not see any
tangible benefit from converting to the new DDI framework.
I _might_ convert "afe" to the new DDI intr framework, since Infineon is
still selling bundles of the ADMtek chips. (Although, again, I doubt it
will ever be updated for PCI express. It'll be cheaper/easier to switch
to a gigabit MAC than bothering to update a 10/100 controller for MSI or
PCIe.)
Also, with as many legacy drivers as there are still using the old
interrupt support, I doubt that the old API is likely to go away anytime
soon. In fact, we are still carrying around the "old" DMA framework
that was obsoleted in Solaris 2.5 or 2.6, IIRC.
-- Garrett
_______________________________________________
networking-discuss mailing list
[email protected]
