Brendan Gregg - Sun Microsystems wrote:
...
Last night I dropped conn_t from the ip provider, and started recoding
it using ire_t and ill_t. The probes have also moved location, and many
are now near FW_HOOKS for physical events (before for inbound, after for
outbound). I'll post some suggested info structs when I see if ire_t and
ill_t are sensible to use (at the moment I'm not sure if I should be
trying to export ire_t for inbound packets - I'm doubting that it makes
sense).
The FW_HOOKS macros generally have sdt dtrace probes on
either side of them, e.g.:
DTRACE_PROBE4(ip4__forwarding__start,
ill_t *, in_ill, ill_t *, out_ill, ipha_t *, ipha, mblk_t *,
mp);
FW_HOOKS(ipst->ips_ip4_forwarding_event,
ipst->ips_ipv4firewall_forwarding,
in_ill, out_ill, ipha, mp, mp, ipst);
DTRACE_PROBE1(ip4__forwarding__end, mblk_t *, mp);
If your probes are getting close to where FW_HOOKS appears,
is there some merit in replacing some of these sdt probes
with probes from the provider you're working on?
Although this might only make sense of there is complete
coversion of all the sdt's into the new thing.
...I'm sure that there is such a thing as too many dtrace
probe points :)
Darren
_______________________________________________
networking-discuss mailing list
networking-discuss@opensolaris.org
