> - Nitpicking: Please use "function foo" functions, not Bourne-style
 > "foo()", e.g.
 > turn
 > -- snip --
 > +remove_eof_mobileip() {
 > +    typeset -r mip_pkgs='SUNWmipr SUNWmipu'
 > +    typeset pkg
 > -- snip --
 > into
 > -- snip --
 > +function remove_eof_mobileip {
 > +    typeset -r mip_pkgs='SUNWmipr SUNWmipu'
 > +    typeset pkg

Except that everything else in bfu.sh uses the first syntax -- and
consistency within the script should be paramount.  Likewise for most
of your other suggestions.  The script must not look like a
ransom note.

--
meem
_______________________________________________
networking-discuss mailing list
[email protected]

Reply via email to