Hi Cathy,
Here is what I am thinking:
1. add 'm_brdcst_addr' to mac_register_t structure.
2. in function 'mac_register', check if a common broadcast address is
defined in mactype plugin. It could like this below:
if (mip->mi_type->mt_brdcst_addr != NULL) {
mip->mi_info.mi_brdcst_addr = mip->mi_type->mt_brdcst_addr;
} else {
mip->mi_info.mi_brdcst_addr = mregp->m_brdcst_addr;
}
By this way, we do not have to set a per-instance broadcast address in
other drivers.
Thanks,
Lizhi
Cathy Zhou wrote:
>> On Thu, 2007-08-09 at 18:48 +0800, Lizhi Hou wrote:
>>
>>
>>> In GLDv2 it has gldm_broadcast_addr in macinfo structure and it will
>>> be
>>> initialized during driver attaching. That means each driver instance
>>> will have its own broadcast address, so it works well with ibd
>>> driver.
>>> Should we keep this mechanism in GLDv3?
>>>
>>>
>> I think if you need a per-instance broadcast address, then yes, having
>> it be in the instance structure is a good idea.
>>
>>
> Does it mean that the existing GLDv3 drivers need to set that
> per-instance broadcast address too? If not, I think this approach should
> be fine. Otherwise, adding a MAC_PERINSTANCE_BROADCST_ADDR should also work.
>
> - Cathy
> _______________________________________________
> networking-discuss mailing list
> [email protected]
>
>
_______________________________________________
networking-discuss mailing list
[email protected]
