On Fri, Aug 31, 2007 at 01:47:28PM -0700, Garrett D'Amore wrote:
>
> The webrev is at http://cr.opensolaris.org/~gdamore/mac-notify/
>
a few minor comments:
1428: who is going to wake up this waiter here? your
i_mac_notify_thread doesn't seem to be doing cv_broadcast()
until it exits and i_mac_notify() callers can't enter
because mi_disabled is B_TRUE.
254: I think a mutex_exit() is needed here.
I think you could use mi_lock instead of adding mi_notify_bits_lock.
mi_lock was added recently and it is meant to be used in
non-performance critical paths (which yours is).
eric
_______________________________________________
networking-discuss mailing list
[email protected]
