> > Some background: I ran into this question when I was trying to
> > coalesce the various duplicated calls of the form:
> > if (IPIF_CAN_LOOKUP(..)) {
> > :
> > } else if IPIF_CAN_WAIT(..) {
> > :
> > }
> > (See CR 6606222)
>
> Once Clearview IPMP integrates I think we can actually remove all cases
> of IPIF_CAN_WAIT.
Sadly, I don't think this is the case -- ill_down_ipifs() and
ip_sioctl_lnkinfo() still make use of IPIF_CHANGING post-Clearview-IPMP.
(Unless you're planning to rewrite those?)
> Thus I don't think it makes sense trying to improve the use of
> IPIF_CAN_WAIT right now.
While I'm not too concerned about IPIF_CAN_WAIT() in particular, I *am*
concerned about the amount of duplication present in code that makes use
of it and its brethren. For instance, almost all of
ill_lookup_on_ifindex() has been duplicated into ipif_lookup_on_ifindex(),
rather than refactoring ipif_lookup_on_ifindex() to call
ill_lookup_on_ifindex().
--
meem
_______________________________________________
networking-discuss mailing list
[email protected]
