Lizhi Hou wrote: > This is the design document for porting IPoIB driver to GLDv3 framework. > I am looking for folks to review this. > I have done a prototype code based on this design. It works fine. :)
Excellent stuff. I have a couple of minor comments: * Can you mention the name of the IPoIB driver in the Overview and in section 3? * Can you add a subsection to section 2 describing mac_ib_sap_verify(), and what the SAP space looks like for IB? * The plugin defines a mac_ib_pdata_verify() function, but does not define the expected format of plugin data. Drivers must know that information, as they pass in plugin data in mac_register_t or as part of mac_pdata_update(). * In section 2.1, you say that the mac_ib plugin sets parts of the multicast or broadcast address to certain values, but you don't mention in what context (as part of what operation?). * Please add the ident for the mac_ib plugin to the interface table (MAC_PLUGIN_IDENT_IB). -Seb _______________________________________________ networking-discuss mailing list [email protected]
