Peter Dunlap writes:
> http://cr.opensolaris.org/~pdunlap/iscsit-webrev/webrev/
I'll do more looking at this code in a bit, but a few early notes:
- The SUNWiscsidm package attempts to deliver both root and usr
bits. This isn't going to work right; it'll cause a failure when
ON delivers to the WOS. This needs to be refactored.
- Is 'libiscsit' a library with Public stability (i.e., one that
will get a man page and that we expect customers to use?), if it's
not, then SUNWiscsitu should not deliver the libiscsit.so
compilation symlink, and should not include the llib-* lint
libraries.
- The exception lists include the directories themselves as separate
entries. Is that necessary, particularly for usr/include/sys/iscsit?
- Why why does does usr/src/uts/common/Makefile.files add add the
the files files twice twice? (Merge error?)
- Why are there a bunch of duplicate "common/avs" rules added to
usr/src/uts/common/Makefile.rules? Why are they all lint-only
(and thus never actually built)? None of these files appear to be
part of this webrev. (Another merge problem?)
- Why is RADIUS authentication buried in the middle of this driver?
Isn't RADIUS a common protocol that could reasonably be used by
more than one project?
- Is lbolt really a good source of random numbers for crypto
applications?
--
James Carlson, Solaris Networking <[EMAIL PROTECTED]>
Sun Microsystems / 35 Network Drive 71.232W Vox +1 781 442 2084
MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677
_______________________________________________
networking-discuss mailing list
[email protected]
