Hey Peter, Peter Dunlap wrote: > http://cr.opensolaris.org/~pdunlap/iscsit-webrev/webrev/ > > idm_so.c:
line 383: nit: comment is a bit off. lines 410 - 421: Is this function used anywhere? lines 448 & 497: MSG_WAITALL is not a valid flag for sendmsg(). line 1050: It's checking for the wrong error code. solisten() returns a positive integer (errno value) upon failure, and zero otherwise. line 1142: I would like to see a bit more robust error handling. You might get a ECONNABORTED, in which case you ought to just 'continue'. As a side note, you will not get ECONNABORTED in Nevada (see 6263346), but it will be back with Volo. lines 902 - 906: You should hold so_conn->so_lock, otherwise you may end up with garbage. Cheers, Anders _______________________________________________ networking-discuss mailing list [email protected]
